Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.9] Fix the problem of username being case-insensitive and logging in without permissions #4570

Conversation

halo-dev-bot
Copy link
Collaborator

This is an automated cherry-pick of #4552

/assign JohnNiang

修复因大小写问题导致登录后无权限的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 7, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and ruibaby September 7, 2023 05:52
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2023
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #4570 (71956b2) into release-2.9 (bd4c9c6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@              Coverage Diff               @@
##             release-2.9    #4570   +/-   ##
==============================================
  Coverage          61.02%   61.02%           
  Complexity          2560     2560           
==============================================
  Files                373      373           
  Lines              13149    13150    +1     
  Branches             937      937           
==============================================
+ Hits                8024     8025    +1     
  Misses              4670     4670           
  Partials             455      455           
Files Changed Coverage Δ
...un/halo/app/security/DefaultUserDetailService.java 100.00% <100.00%> (ø)

@JohnNiang JohnNiang added this to the 2.9.x milestone Sep 7, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 7, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit bfb37f8 into halo-dev:release-2.9 Sep 7, 2023
2 checks passed
@JohnNiang JohnNiang modified the milestones: 2.9.x, 2.9.1 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants