-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: i18n key of theme remote download tab label #4576
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
/cherrypick release-2.9 |
@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #4576 +/- ##
============================================
+ Coverage 61.02% 61.07% +0.05%
- Complexity 2560 2566 +6
============================================
Files 373 374 +1
Lines 13149 13162 +13
Branches 937 937
============================================
+ Hits 8024 8039 +15
Misses 4670 4670
+ Partials 455 453 -2 see 5 files with indirect coverage changes 📢 Have feedback on the report? Share it here. |
/cherrypick release-2.9 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@ruibaby: new pull request created: #4577 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #4576 /assign ruibaby ```release-note 修复 Console 端主题远程下载标签的英文语言包键名,使其可以正确显示标签标题。 ```
What type of PR is this?
/area console
/kind bug
/milestone 2.10.x
What this PR does / why we need it:
修复了主题远程下载标签的英文语言包键,使其可以正确显示标签标题。
Does this PR introduce a user-facing change?