Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n key of theme remote download tab label #4576

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 8, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.10.x

What this PR does / why we need it:

修复了主题远程下载标签的英文语言包键,使其可以正确显示标签标题。

Does this PR introduce a user-facing change?

修复 Console 端主题远程下载标签的英文语言包键名,使其可以正确显示标签标题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 8, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 8, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 8, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove September 8, 2023 02:31
@ruibaby
Copy link
Member Author

ruibaby commented Sep 8, 2023

/cherrypick release-2.9

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #4576 (3153cf3) into main (2baf6ae) will increase coverage by 0.05%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #4576      +/-   ##
============================================
+ Coverage     61.02%   61.07%   +0.05%     
- Complexity     2560     2566       +6     
============================================
  Files           373      374       +1     
  Lines         13149    13162      +13     
  Branches        937      937              
============================================
+ Hits           8024     8039      +15     
  Misses         4670     4670              
+ Partials        455      453       -2     

see 5 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@JohnNiang
Copy link
Member

/cherrypick release-2.9

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JohnNiang
Copy link
Member

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 31675db into halo-dev:main Sep 8, 2023
2 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4577

In response to this:

/cherrypick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Sep 8, 2023
This is an automated cherry-pick of #4576

/assign ruibaby

```release-note
修复 Console 端主题远程下载标签的英文语言包键名,使其可以正确显示标签标题。
```
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants