Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bundle resources cache version may duplicate #4591

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: bundle resources cache version may duplicate #4591

merged 1 commit into from
Sep 18, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Sep 11, 2023 •
edited by ruibaby
Loading

What type of PR is this?

/kind improvement
/area core
/milestone 2.10.x

What this PR does / why we need it:

修复 bundle resource 的缓存 key 生成可能会重复的问题

Which issue(s) this PR fixes:

Fixes #4586

Does this PR introduce a user-facing change?

修复插件捆绑资源（bundle.js / bundle.css）的缓存 key 生成可能会重复的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 11, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 11, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen September 11, 2023 10:45
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 11, 2023
@guqing
Copy link
Member Author

guqing commented Sep 11, 2023

/cherry-pick release-2.9

@halo-dev-bot
Copy link
Collaborator

@guqing: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #4591 (d4a7e8a) into main (e13563b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #4591      +/-   ##
============================================
+ Coverage     61.04%   61.11%   +0.06%     
- Complexity     2566     2570       +4     
============================================
  Files           374      374              
  Lines         13168    13171       +3     
  Branches        938      938              
============================================
+ Hits           8039     8049      +10     
+ Misses         4676     4669       -7     
  Partials        453      453
Files Changed Coverage Δ
...core/extension/service/impl/PluginServiceImpl.java 62.39% <100.00%> (+7.13%) ⬆️

ruibaby
ruibaby reviewed Sep 12, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 12, 2023
@guqing
Copy link
Member Author

guqing commented Sep 15, 2023

/cc @halo-dev/sig-halo

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 15, 2023

@guqing: GitHub didn't allow me to request PR reviews from the following users: halo-dev/sig-halo.

Note that only halo-dev members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @halo-dev/sig-halo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby
Copy link
Member

ruibaby commented Sep 18, 2023

/cherry-pick release-2.9

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@guqing guqing requested a review from JohnNiang September 18, 2023 09:43
@guqing
Copy link
Member Author

guqing commented Sep 18, 2023

/ping @halo-dev/sig-halo

JohnNiang
JohnNiang approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 84f413d into halo-dev:main Sep 18, 2023
@halo-dev-bot
Copy link
Collaborator

@guqing: new pull request created: #4626

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot halo-dev-bot mentioned this pull request Sep 18, 2023
Merged
@guqing guqing deleted the fix/4586 branch September 18, 2023 15:35
@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. and removed kind/improvement Categorizes issue or PR as related to a improvement. labels Sep 18, 2023
f2c-ci-robot bot pushed a commit that referenced this pull request Sep 18, 2023
@halo-dev-bot
[release-2.9] fix: bundle resources cache version may duplicate (#4626)
4fd076f 
This is an automated cherry-pick of #4591

/assign guqing

```release-note
修复 bundle resource 的缓存 key 生成可能会重复的问题
```
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 20, 2023
@ruibaby ruibaby mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@wan92hen wan92hen Awaiting requested review from wan92hen

Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

插件的 bundle.js 缓存 key 生成规则可能重复
4 participants
@guqing @halo-dev-bot @ruibaby @JohnNiang