Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing ui permission condition about users #4619

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 18, 2023

What type of PR is this?

/kind bug
/area console
/milestone 2.10.x

What this PR does / why we need it:

修复关于用户数据相关的 UI 权限判断缺失的问题。

image

Special notes for your reviewer:

需要测试:

  1. 创建一个仅包含文章权限的角色并赋予给某个用户。
  2. 使用这个用户登录,查看文章管理页面,观察是否有用户接口的请求,以及页面是否有报错。

Does this PR introduce a user-facing change?

优化 Console 端关于用户数据相关的 UI 权限判断

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 18, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from wan92hen and wzrove September 18, 2023 07:06
@f2c-ci-robot f2c-ci-robot bot added the area/console Issues or PRs related to the Halo Console label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4619 (e346bea) into main (da2d56e) will not change coverage.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4619   +/-   ##
=========================================
  Coverage     61.04%   61.04%           
  Complexity     2566     2566           
=========================================
  Files           374      374           
  Lines         13168    13168           
  Branches        938      938           
=========================================
  Hits           8039     8039           
  Misses         4676     4676           
  Partials        453      453           

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 18, 2023
@JohnNiang
Copy link
Member

IMO:提供一个文章作者查询接口来适配这个功能可能比较好。

@ruibaby
Copy link
Member Author

ruibaby commented Sep 18, 2023

IMO:提供一个文章作者查询接口来适配这个功能可能比较好。

筛选出发布过文章的用户?那页面、附件、评论等使用到的地方可能也需要提供。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO,这是一个临时解决方案,建议后续提供对应的 API 来筛选作者。

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang, wzrove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang merged commit f953201 into halo-dev:main Sep 22, 2023
2 checks passed
@ruibaby ruibaby deleted the fix/user-ui-permissions-check branch September 22, 2023 08:14
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants