-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing ui permission condition about users #4619
fix: missing ui permission condition about users #4619
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4619 +/- ##
=========================================
Coverage 61.04% 61.04%
Complexity 2566 2566
=========================================
Files 374 374
Lines 13168 13168
Branches 938 938
=========================================
Hits 8039 8039
Misses 4676 4676
Partials 453 453 |
Signed-off-by: Ryan Wang <i@ryanc.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO:提供一个文章作者查询接口来适配这个功能可能比较好。 |
筛选出发布过文章的用户?那页面、附件、评论等使用到的地方可能也需要提供。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO,这是一个临时解决方案,建议后续提供对应的 API 来筛选作者。
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang, wzrove The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area console
/milestone 2.10.x
What this PR does / why we need it:
修复关于用户数据相关的 UI 权限判断缺失的问题。
Special notes for your reviewer:
需要测试:
Does this PR introduce a user-facing change?