Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configration route for auth provider item #4635

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 20, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.10.x

What this PR does / why we need it:

为认证方式添加更直观的配置页面入口

image

Which issue(s) this PR fixes:

Fixes #4634

Does this PR introduce a user-facing change?

为 Console 端认证方式管理添加更直观的配置页面入口

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang September 20, 2023 06:32
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove September 20, 2023 06:32
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #4635 (c318fe4) into main (927e45b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4635   +/-   ##
=========================================
  Coverage     60.98%   60.98%           
  Complexity     2610     2610           
=========================================
  Files           378      378           
  Lines         13551    13551           
  Branches        959      959           
=========================================
  Hits           8264     8264           
  Misses         4822     4822           
  Partials        465      465           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@LIlGG
Copy link
Member

LIlGG commented Sep 26, 2023

/lgtm

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 9b310ca into halo-dev:main Sep 27, 2023
2 checks passed
@JohnNiang JohnNiang modified the milestones: 2.10.x, 2.10.0 Sep 27, 2023
@ruibaby ruibaby deleted the feat/add-config-route-for-auth-provider branch August 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

用户身份认证列表需要添加一个设置按钮
4 participants