Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing permission check in plugin installation tabs and theme list tabs extension points #4636

Merged
merged 1 commit into from
Sep 22, 2023
Merged

fix: missing permission check in plugin installation tabs and theme list tabs extension points #4636

merged 1 commit into from
Sep 22, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 20, 2023 •
edited by JohnNiang
Loading

What type of PR is this?

/area console
/kind bug
/milestone 2.10.x

What this PR does / why we need it:

修复主题管理选项卡和插件安装界面选项卡扩展点没有添加 UI 权限检测的问题。

Which issue(s) this PR fixes:

Fixes #4632

Does this PR introduce a user-facing change?

修复主题管理选项卡和插件安装界面选项卡扩展点没有添加 UI 权限检测的问题

@ruibaby
fix: missing permission check in plugin installation tabs and theme l…
e9dd0e1 
…ist tabs extension points

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/console Issues or PRs related to the Halo Console labels Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 20, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wzrove September 20, 2023 07:30
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023 •
edited
Loading

Codecov Report

Merging #4636 (e9dd0e1) into main (84f413d) will not change coverage.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4636   +/-   ##
=========================================
  Coverage     61.11%   61.11%           
  Complexity     2570     2570           
=========================================
  Files           374      374           
  Lines         13171    13171           
  Branches        938      938           
=========================================
  Hits           8049     8049           
  Misses         4669     4669           
  Partials        453      453

JohnNiang
JohnNiang approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
guqing
guqing reviewed Sep 22, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@JohnNiang JohnNiang merged commit 9fbbd40 into halo-dev:main Sep 22, 2023
2 checks passed
@ruibaby
Copy link
Member Author

ruibaby commented Sep 22, 2023

/cherry-pick release-2.9

@ruibaby ruibaby deleted the fix/ui-permissions-in-theme-plugin-tabs branch September 22, 2023 09:24
@halo-dev-bot halo-dev-bot mentioned this pull request Sep 22, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4647

In response to this:

/cherry-pick release-2.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Sep 22, 2023
@halo-dev-bot
[release-2.9] fix: missing permission check in plugin installation ta…
12d25a4 
…bs and theme list tabs extension points (#4647)

This is an automated cherry-pick of #4636

/assign ruibaby

```release-note
None
```
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 22, 2023
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@wzrove wzrove Awaiting requested review from wzrove

Assignees

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

主题和插件安装界面选项卡扩展没有适配 UI 权限设置
4 participants
@ruibaby @halo-dev-bot @JohnNiang @guqing