Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump formkit version to 1.1.0 #4642

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 22, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.10.x

What this PR does / why we need it:

升级 FormKit 版本至 1.1.0 正式版。

see https://formkit.com/changelog

Special notes for your reviewer:

测试 Console 的各个表单是否正常工作即可。

Does this PR introduce a user-facing change?

升级 FormKit 版本至 1.1.0 正式版。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Sep 22, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 22, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove September 22, 2023 03:45
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #4642 (56c362c) into main (7de97e4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4642   +/-   ##
=========================================
  Coverage     61.11%   61.11%           
  Complexity     2570     2570           
=========================================
  Files           374      374           
  Lines         13171    13171           
  Branches        938      938           
=========================================
  Hits           8049     8049           
  Misses         4669     4669           
  Partials        453      453           

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit d3e296d into halo-dev:main Sep 22, 2023
2 checks passed
@ruibaby ruibaby deleted the chore/bump-formkit-1.1.0 branch September 22, 2023 07:48
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants