-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: plugin self tab extension point not working when no setting definition #4659
fix: plugin self tab extension point not working when no setting definition #4659
Conversation
…nition Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov Report
@@ Coverage Diff @@
## main #4659 +/- ##
=========================================
Coverage 60.98% 60.98%
Complexity 2610 2610
=========================================
Files 378 378
Lines 13551 13551
Branches 959 959
=========================================
Hits 8264 8264
Misses 4822 4822
Partials 465 465 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind bug
/milestone 2.10.x
What this PR does / why we need it:
修复当插件没有设置表单定义时,详情选项卡扩展点不生效的问题。
Which issue(s) this PR fixes:
Fixes #4633
Special notes for your reviewer:
可以通过以下插件进行测试:
Does this PR introduce a user-facing change?