Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin self tab extension point not working when no setting definition #4659

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 25, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.10.x

What this PR does / why we need it:

修复当插件没有设置表单定义时,详情选项卡扩展点不生效的问题。

image

Which issue(s) this PR fixes:

Fixes #4633

Special notes for your reviewer:

可以通过以下插件进行测试:

  1. plugin-migrate-1.2.0-SNAPSHOT.jar.zip
  2. https://github.com/halo-dev/plugin-app-store/releases/tag/v1.0.0-alpha.4
  3. https://github.com/halo-dev/plugin-s3

Does this PR introduce a user-facing change?

修复当插件没有设置表单定义时,详情选项卡扩展点不生效的问题。

…nition

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note-none Denotes a PR that doesn't merit a release note. area/console Issues or PRs related to the Halo Console labels Sep 25, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 25, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #4659 (1968bdb) into main (5fa0056) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4659   +/-   ##
=========================================
  Coverage     60.98%   60.98%           
  Complexity     2610     2610           
=========================================
  Files           378      378           
  Lines         13551    13551           
  Branches        959      959           
=========================================
  Hits           8264     8264           
  Misses         4822     4822           
  Partials        465      465           

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 927e45b into halo-dev:main Sep 25, 2023
2 checks passed
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console 端插件详情选项卡扩展在没有插件设置时不生效
3 participants