Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: user detail page structure #4664

Merged
merged 1 commit into from
Sep 26, 2023
Merged

refactor: user detail page structure #4664

merged 1 commit into from
Sep 26, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Sep 26, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.10.x

What this PR does / why we need it:

重构 Console 端用户详情页面的结构。

  1. 提高代码可读性。
  2. 使用问号参数来区分不同的选项卡。
  3. 封装头像修改相关的代码为组件。

Special notes for your reviewer:

测试用户详情页面的所有功能是否正常。

Does this PR introduce a user-facing change?

重构 Console 端用户详情页面的代码结构。

@ruibaby
refactor: user detail page structure
be4bb3a 
Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing September 26, 2023 09:21
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from QuentinHsu September 26, 2023 09:21
@ruibaby ruibaby mentioned this pull request Sep 26, 2023
Merged
JohnNiang
JohnNiang approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
guqing
guqing reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot merged commit 470b0de into halo-dev:main Sep 26, 2023
2 checks passed
f2c-ci-robot bot pushed a commit to halo-dev/plugin-app-store that referenced this pull request Sep 26, 2023
@ruibaby
refactor: update halo pat management page address (#37)
807524b 
更新创建 PAT 的地址。

Ref halo-dev/halo#4664

<img width="597" alt="image" src="https://github.com/halo-dev/plugin-app-store/assets/21301288/b50db329-022e-443a-9a59-6b777fa43495">

```release-note
None
```
@JohnNiang JohnNiang modified the milestones: 2.10.x, 2.10.0 Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@QuentinHsu QuentinHsu Awaiting requested review from QuentinHsu

Assignees

@JohnNiang JohnNiang

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ruibaby @JohnNiang @guqing