Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to PF4J 3.10.0 #4666

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind cleanup
/area core
/milestone 2.10.0

What this PR does / why we need it:

Upgrade to PF4J 3.10.0.

Does this PR introduce a user-facing change?

升级依赖 PF4J 至 3.10.0

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.0 milestone Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Sep 26, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from minliacom and ruibaby September 26, 2023 16:06
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #4666 (18ea8fb) into main (470b0de) will not change coverage.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4666   +/-   ##
=========================================
  Coverage     61.02%   61.02%           
  Complexity     2610     2610           
=========================================
  Files           378      378           
  Lines         13541    13541           
  Branches        958      958           
=========================================
  Hits           8264     8264           
  Misses         4812     4812           
  Partials        465      465           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 6106096 into halo-dev:main Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants