Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: upgrade the editor dependent version and add a pnpm link #4669

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Sep 27, 2023

What type of PR is this?

/kind improvement

What this PR does / why we need it:

升级编辑器版本,增加新的扩展,例如拖拽、分栏等。
移除了 @tiptap/vue-3 依赖包,此包已经在 @halo-dev/richtext-editor 中进行提供。
新增 link:editor 命令,可以本地引入 richtext-editor 的依赖,进行本地调试。

How to test it?

使用编辑器,保证编辑器功能正常无误即可。并测试编辑器新加功能。

Does this PR introduce a user-facing change?

None

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 27, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and wzrove September 27, 2023 09:05
@LIlGG
Copy link
Member Author

LIlGG commented Sep 27, 2023

/hold 等待编辑器发版之后对依赖版本进行调整

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@LIlGG LIlGG changed the title WIP: pref: upgrade the editor dependent version and add a pnpm link pref: upgrade the editor dependent version and add a pnpm link Sep 27, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 27, 2023
@LIlGG
Copy link
Member Author

LIlGG commented Sep 27, 2023

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4669 (f4360b7) into main (ce0e02a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4669   +/-   ##
=========================================
  Coverage     61.02%   61.02%           
  Complexity     2610     2610           
=========================================
  Files           379      379           
  Lines         13612    13612           
  Branches        960      960           
=========================================
  Hits           8307     8307           
  Misses         4838     4838           
  Partials        467      467           

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Sep 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit e119b63 into halo-dev:main Sep 27, 2023
2 checks passed
@ruibaby ruibaby added this to the 2.10.0 milestone Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants