Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add encryption setting for email notifier #4686

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 8, 2023

What type of PR is this?

/kind improvement
/area core
/milestone 2.10.x

What this PR does / why we need it:

为邮件通知发件设置增加加密方式配置

Which issue(s) this PR fixes:

Fixes #4674

Does this PR introduce a user-facing change?

为邮件通知发件设置增加加密方式配置

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from lan-yonghui and wan92hen October 8, 2023 03:30
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #4686 (99ab68d) into main (b2d7221) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4686      +/-   ##
============================================
- Coverage     61.68%   61.65%   -0.03%     
  Complexity     2781     2781              
============================================
  Files           402      402              
  Lines         14595    14602       +7     
  Branches       1014     1017       +3     
============================================
  Hits           9003     9003              
- Misses         5101     5108       +7     
  Partials        491      491              
Files Coverage Δ
.../java/run/halo/app/notification/EmailNotifier.java 3.94% <0.00%> (-0.41%) ⬇️

@ruibaby
Copy link
Member

ruibaby commented Oct 8, 2023

/hold

等待 #4685 合并。

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2023
@JohnNiang
Copy link
Member

/unhold

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2023
@ruibaby
Copy link
Member

ruibaby commented Oct 8, 2023

/unhold

@ruibaby ruibaby added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@f2c-ci-robot f2c-ci-robot bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 8, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 815f6b8 into halo-dev:main Oct 8, 2023
2 checks passed
@guqing guqing deleted the refactor/4674 branch October 8, 2023 09:44
@ruibaby ruibaby modified the milestones: 2.10.x, 2.10.0 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望邮件通知支持SSL
3 participants