-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make attachment list item operations extendable #4689
feat: make attachment list item operations extendable #4689
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
cc @longjuan |
Codecov Report
@@ Coverage Diff @@
## main #4689 +/- ##
=========================================
Coverage 61.73% 61.73%
Complexity 2781 2781
=========================================
Files 402 402
Lines 14584 14584
Branches 1011 1011
=========================================
Hits 9003 9003
Misses 5092 5092
Partials 489 489 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind feature
/milestone 2.10.x
What this PR does / why we need it:
附件管理列表项的操作按钮支持被插件扩展。
Which issue(s) this PR fixes:
Fixes #4667
Special notes for your reviewer:
需要测试附件的关于列表的已有功能是否正常。
如果需要测试扩展点是否有效,可以使用此插件测试:plugin-s3-1.5.0-SNAPSHOT.jar.zip
Does this PR introduce a user-facing change?