Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display add icon when user avatar is not setting #4694

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Oct 9, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.10.x

What this PR does / why we need it:

当用户未设置头像时,头像显示添加图标,能够更好的提示用户如何设置头像。

image

Which issue(s) this PR fixes:

Fixes #4693

Special notes for your reviewer:

  1. 测试未设置头像时,是否添加添加图标。
  2. 测试设置头像之后,鼠标移动到头像时,是否显示修改图标。

Does this PR introduce a user-facing change?

优化 Console 端个人资料的头像显示,未设置头像时显示添加图标。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 9, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Oct 9, 2023
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Oct 9, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang October 9, 2023 04:20
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

image

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 0b8e0d9 into halo-dev:main Oct 10, 2023
2 checks passed
@ruibaby ruibaby deleted the feat/improve-user-avatar-setting branch October 10, 2023 03:13
@JohnNiang JohnNiang modified the milestones: 2.10.x, 2.10.0 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

没有找到用户头像设置的地方。
3 participants