Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect results when filtering unpublished posts #4736

Merged
merged 1 commit into from
Oct 23, 2023
Merged

fix: incorrect results when filtering unpublished posts #4736

merged 1 commit into from
Oct 23, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 17, 2023 •
edited by ruibaby
Loading

What type of PR is this?

/kind bug
/area core
/milestone 2.10.x

What this PR does / why we need it:

修复筛选未发布文章时结果不正确的问题

Which issue(s) this PR fixes:

Fixes #4730

Does this PR introduce a user-facing change?

修复筛选未发布文章时结果不正确的问题。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 17, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Oct 17, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #4736 (a1cbb26) into main (9e33a81) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main    #4736      +/-   ##
============================================
- Coverage     61.58%   61.58%   -0.01%     
  Complexity     2797     2797              
============================================
  Files           403      403              
  Lines         14725    14727       +2     
  Branches       1023     1024       +1     
============================================
+ Hits           9068     9069       +1     
  Misses         5165     5165              
- Partials        492      493       +1
Files Coverage Δ
.../app/core/extension/reconciler/PostReconciler.java 68.20% <50.00%> (-0.22%) ⬇️

ruibaby
ruibaby reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2023
@ruibaby
Copy link
Member

ruibaby commented Oct 19, 2023

/cherrypick release-2.10

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby modified the milestones: 2.10.x, 2.11.x Oct 19, 2023
JohnNiang
JohnNiang approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit baca058 into halo-dev:main Oct 23, 2023
2 checks passed
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4763

In response to this:

/cherrypick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@halo-dev-bot halo-dev-bot mentioned this pull request Oct 23, 2023
Merged
f2c-ci-robot bot pushed a commit that referenced this pull request Oct 23, 2023
@halo-dev-bot
[release-2.10] fix: incorrect results when filtering unpublished posts (
f019cc9 
#4763)

This is an automated cherry-pick of #4736

/assign ruibaby

```release-note
修复筛选未发布文章时结果不正确的问题
```
@guqing guqing deleted the bugfix/4730 branch October 23, 2023 08:48
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

Assignees

@JohnNiang JohnNiang

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

文章列表筛选选择未发布状态时无法展示文章列表
4 participants
@guqing @ruibaby @halo-dev-bot @JohnNiang