Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve the issue of occasional blank annotation and error occurrences #4772

Merged
merged 1 commit into from
Oct 26, 2023
Merged

fix: resolve the issue of occasional blank annotation and error occurrences #4772

merged 1 commit into from
Oct 26, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Oct 26, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

在获取自定义元数据时，将空白 key 与重复的 key 过滤，用于解决可能出现的额外空白元数据及报错问题。

How to test it?

尝试点击编辑文章 -> 设置，查看是否有额外空白元数据的出现。

由于是概率性问题，因此若本地环境未复现，则需要使用生产环境进行验证。

Which issue(s) this PR fixes:

Fixes #4764

Does this PR introduce a user-facing change?

解决文章设置中可能出现空白元数据的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Oct 26, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and wzrove October 26, 2023 04:42
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #4772 (dc1e7fa) into main (e20ab8f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4772   +/-   ##
=========================================
  Coverage     61.50%   61.50%           
  Complexity     2798     2798           
=========================================
  Files           403      403           
  Lines         14772    14772           
  Branches       1029     1029           
=========================================
  Hits           9086     9086           
  Misses         5193     5193           
  Partials        493      493

guqing
guqing reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2023
ruibaby
ruibaby reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ruibaby
Copy link
Member

ruibaby commented Oct 26, 2023

/cherry-pick release-2.10

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ruibaby
ruibaby reviewed Oct 26, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@ruibaby ruibaby added this to the 2.11.x milestone Oct 26, 2023
@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 2dbfbd1 into halo-dev:main Oct 26, 2023
2 checks passed
@halo-dev-bot halo-dev-bot mentioned this pull request Oct 26, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4774

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Oct 26, 2023
@halo-dev-bot
[release-2.10] fix: resolve the issue of occasional blank annotation …
0be5e7b 
…and error occurrences (#4774)

This is an automated cherry-pick of #4772

/assign ruibaby

```release-note
解决文章设置中可能出现空白元数据的问题
```
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guqing guqing guqing left review comments

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang Awaiting requested review from JohnNiang

@wzrove wzrove Awaiting requested review from wzrove

Assignees

@ruibaby ruibaby

@guqing guqing

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.

文章元数据错误
5 participants
@LIlGG @ruibaby @halo-dev-bot @guqing @JohnNiang