Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: autofill if post is published but no publish time #4775

Merged
merged 2 commits into from
Oct 27, 2023
Merged

refactor: autofill if post is published but no publish time #4775

merged 2 commits into from
Oct 27, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Oct 27, 2023 •
edited by ruibaby
Loading

What type of PR is this?

/kind improvement
/area core
/milestone 2.10.x

What this PR does / why we need it:

如果文章是发布状态但没有发布时间则自动填充

Does this PR introduce a user-facing change?

修复文章可能因为没有发布时间导致发布失败的问题。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note-none Denotes a PR that doesn't merit a release note. labels Oct 27, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.10.x milestone Oct 27, 2023
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Oct 27, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and minliacom October 27, 2023 03:20
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #4775 (bfa9e38) into main (2dbfbd1) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #4775      +/-   ##
============================================
- Coverage     61.50%   61.49%   -0.02%     
  Complexity     2798     2798              
============================================
  Files           403      403              
  Lines         14772    14776       +4     
  Branches       1029     1031       +2     
============================================
  Hits           9086     9086              
- Misses         5193     5195       +2     
- Partials        493      495       +2
Files Coverage Δ
.../app/core/extension/reconciler/PostReconciler.java 67.42% <0.00%> (-0.78%) ⬇️
...ore/extension/reconciler/SinglePageReconciler.java 50.94% <0.00%> (-0.49%) ⬇️

@ruibaby ruibaby modified the milestones: 2.10.x, 2.11.x Oct 27, 2023
@ruibaby
Copy link
Member

ruibaby commented Oct 27, 2023

/cherry-pick release-2.10

@halo-dev-bot
Copy link
Collaborator

@ruibaby: once the present PR merges, I will cherry-pick it on top of release-2.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ruibaby
ruibaby reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2023
@JohnNiang
Copy link
Member

我这里有一个担忧：目前我们还是没有找到在什么地方重置了 publishTime，即使我们手动在 reconciler 中设置了 publishTime，后续仍然有可能被再次重置，现象就是 publishTime 会经常变动。

@guqing
Copy link
Member Author

guqing commented Oct 27, 2023

我这里有一个担忧：目前我们还是没有找到在什么地方重置了 publishTime，即使我们手动在 reconciler 中设置了 publishTime，后续仍然有可能被再次重置，现象就是 publishTime 会经常变动。

确实，但目前不清楚原因产生的原因是什么，不过应该很少会遇到

@ruibaby
Copy link
Member

ruibaby commented Oct 27, 2023 •
edited
Loading

我这里有一个担忧：目前我们还是没有找到在什么地方重置了 publishTime，即使我们手动在 reconciler 中设置了 publishTime，后续仍然有可能被再次重置，现象就是 publishTime 会经常变动。

可以提交一个 issue mark 一下。

JohnNiang
JohnNiang approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

当前修复仅为临时方案，后续将持续探索具体原因。

@f2c-ci-robot
Copy link

f2c-ci-robot bot commented Oct 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit b5094d6 into halo-dev:main Oct 27, 2023
2 checks passed
@halo-dev-bot halo-dev-bot mentioned this pull request Oct 27, 2023
Merged
@halo-dev-bot
Copy link
Collaborator

@ruibaby: new pull request created: #4781

In response to this:

/cherry-pick release-2.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 27, 2023
@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. and removed kind/improvement Categorizes issue or PR as related to a improvement. labels Oct 27, 2023
f2c-ci-robot bot pushed a commit that referenced this pull request Oct 27, 2023
@halo-dev-bot
[release-2.10] refactor: autofill if post is published but no publish…
2070548 
… time (#4781)

This is an automated cherry-pick of #4775

/assign ruibaby

```release-note
修复文章可能因为没有发布时间导致发布失败的问题。
```
@guqing guqing deleted the refactor/publishtime branch October 28, 2023 03:30
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@LIlGG LIlGG Awaiting requested review from LIlGG

@minliacom minliacom Awaiting requested review from minliacom

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@guqing @ruibaby @halo-dev-bot @JohnNiang