Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve the issue of receiving duplicate key error after deleting metadata #4815

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Nov 2, 2023

What type of PR is this?

/kind bug
/area console
/milestone 2.11.x

What this PR does / why we need it:

重构去重元数据的逻辑,解决删除元数据后仍旧提示 key 不能重复的问题。

How to test it?

  1. 在文章列表点击设置按钮
  2. 添加两个个空的元数据,不保存直接关闭设置框。
  3. 再次打开设置框,点击删除空的元数据,查看是否会提示 key 重复。

Does this PR introduce a user-facing change?

解决删除元数据后仍旧提示 key 不能重复的问题

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 2, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 2, 2023
@f2c-ci-robot f2c-ci-robot bot added kind/bug Categorizes issue or PR as related to a bug. area/console Issues or PRs related to the Halo Console labels Nov 2, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from Aanko and ruibaby November 2, 2023 04:17
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #4815 (3aa1328) into main (2d74312) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4815   +/-   ##
=========================================
  Coverage     61.49%   61.49%           
  Complexity     2805     2805           
=========================================
  Files           405      405           
  Lines         14804    14804           
  Branches       1030     1030           
=========================================
  Hits           9103     9103           
  Misses         5205     5205           
  Partials        496      496           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 57b2426 into halo-dev:main Nov 2, 2023
2 checks passed
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants