Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Lombok gradle plugin 8.4 #4849

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind cleanup
/area core
/milestone 2.11.x

What this PR does / why we need it:

Upgrade to Lombok gradle plugin 8.4.

See https://docs.freefair.io/gradle-plugins/8.4/reference/#_installation and https://docs.freefair.io/gradle-plugins/8.4/reference/#_system_requirements for more.

Does this PR introduce a user-facing change?

升级 Lombok Gradle 插件至 8.4

@f2c-ci-robot f2c-ci-robot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 12, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 12, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from lan-yonghui November 12, 2023 15:18
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Nov 12, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from LIlGG November 12, 2023 15:18
@JohnNiang
Copy link
Member Author

/hold

Hold until #4848 merges.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 12, 2023
Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #4849 (48164c7) into main (ee52adf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #4849   +/-   ##
=========================================
  Coverage     61.53%   61.53%           
  Complexity     2811     2811           
=========================================
  Files           406      406           
  Lines         14820    14820           
  Branches       1030     1030           
=========================================
  Hits           9119     9119           
  Misses         5205     5205           
  Partials        496      496           

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold
/lgtm

@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2023
@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2023
Copy link

f2c-ci-robot bot commented Nov 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 841aa96 into halo-dev:main Nov 13, 2023
3 checks passed
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants