Upgrade to Spring Boot 3.2.0-RC2 #4850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
release-note
Codecov Report
@@ Coverage Diff @@
## main #4850 +/- ##
=========================================
Coverage 61.54% 61.55%
Complexity 2810 2810
=========================================
Files 406 406
Lines 14819 14822 +3
Branches 1030 1030
=========================================
+ Hits 9120 9123 +3
Misses 5203 5203
Partials 496 496
|
|
/hold The upgrade seems to have damaged the h2 database. Caused by: org.h2.jdbc.JdbcSQLNonTransientConnectionException: Unsupported database file version or invalid file header in file "/Users/johnniang/halo2-dev/db/halo-next.mv.db" [90048-224]
at org.h2.message.DbException.getJdbcSQLException(DbException.java:690) ~[h2-2.2.224.jar:2.2.224]
at org.h2.message.DbException.getJdbcSQLException(DbException.java:489) ~[h2-2.2.224.jar:2.2.224]
at org.h2.message.DbException.get(DbException.java:212) ~[h2-2.2.224.jar:2.2.224]
at org.h2.mvstore.db.Store.convertMVStoreException(Store.java:158) ~[h2-2.2.224.jar:2.2.224]
at org.h2.mvstore.db.Store.<init>(Store.java:142) ~[h2-2.2.224.jar:2.2.224]
at org.h2.engine.Database.<init>(Database.java:326) ~[h2-2.2.224.jar:2.2.224]
at org.h2.engine.Engine.openSession(Engine.java:92) ~[h2-2.2.224.jar:2.2.224]
at org.h2.engine.Engine.openSession(Engine.java:222) ~[h2-2.2.224.jar:2.2.224]
at org.h2.engine.Engine.createSession(Engine.java:201) ~[h2-2.2.224.jar:2.2.224]
at org.h2.engine.SessionRemote.connectEmbeddedOrServer(SessionRemote.java:343) ~[h2-2.2.224.jar:2.2.224] |
f2c-ci-robot
bot
added
the
do-not-merge/hold
/unhold Due to incompatibility between H2 2.2.224 and H2 2.1.214, we need to backup Halo, clean the working directory, restart Halo and restore data. Or just upgrade old H2 data. See h2database/h2database#3903 for more. |
f2c-ci-robot
bot
added
release-note-action-required
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
|
I'm sorry for upgrading to Spring Boot 3.2.0-RC2 without testing with Halo Docker container. After merge, we will get the following error while running Halo Docker container: Error: Could not find or load main class org.springframework.boot.loader.JarLauncher
Caused by: java.lang.ClassNotFoundException: org.springframework.boot.loader.JarLauncherI will raise another PR to fix the error. See https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.2.0-RC1-Release-Notes#nested-jar-support for more. |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
…4859) #### What type of PR is this? /kind bug /area core #### What this PR does / why we need it: See #4850 (comment) for more. Test steps: ```bash make -C console build ./gradlew clean build -x check docker build -t halo:not-find-main-class . docker run -it --rm -p 8090:8090 -v ~/.halo2:/root/.halo2 halo:not-find-main-class ``` #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
/area core
/milestone 2.11.x
What this PR does / why we need it:
See https://github.com/spring-projects/spring-boot/releases/tag/v3.2.0-RC2 for more.
Does this PR introduce a user-facing change?
Anyone who is using H2 database and wants to upgrade this version has to backup and restore Halo or upgrade old h2 database file manually.