Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for displaying enabled plugins on actuator page #4897

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 23, 2023

What type of PR is this?

/area console
/kind improvement
/milestone 2.11.x

What this PR does / why we need it:

支持在概览页面显示已启动插件和已激活的主题,同时支持复制。

图片

example:

- 外部访问地址: 
- 启动时间: 2023-11-23 11:57
- 版本: 2.11.0-SNAPSHOT
- 构建时间: 2023-11-23 11:57
- Git Commit: cd02332
- Java: OpenJDK Runtime Environment / 17.0.9+0
- 数据库: PostgreSQL / 15.2 (Debian 15.2-1.pgdg110+1)
- 操作系统: Mac OS X / 14.1.1
- 已激活主题: [Walker](https://halo.run/store/apps/app-GHgAR)
- 已启动插件:
  - [highlight.js 代码高亮](https://github.com/halo-sigs/plugin-highlightjs)
  - [Docsme](https://github.com/f2ccloud/plugin-docsme)

Which issue(s) this PR fixes:

Fixes #4690

Special notes for your reviewer:

测试概览页面的信息显示是否正确,以及复制之后的数据是否正确。

Does this PR introduce a user-facing change?

支持在概览页面显示已启动插件和已激活的主题。

@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 23, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 23, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing November 23, 2023 07:35
@f2c-ci-robot f2c-ci-robot bot added the kind/improvement Categorizes issue or PR as related to a improvement. label Nov 23, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen November 23, 2023 07:35
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0bfa170) 56.88% compared to head (5e34714) 56.88%.
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4897   +/-   ##
=========================================
  Coverage     56.88%   56.88%           
  Complexity     2975     2975           
=========================================
  Files           514      514           
  Lines         16912    16912           
  Branches       1273     1273           
=========================================
  Hits           9621     9621           
  Misses         6750     6750           
  Partials        541      541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已激活的主题期望也能够以 Badge 的形式展示。

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2023
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member Author

ruibaby commented Nov 23, 2023

已激活的主题期望也能够以 Badge 的形式展示。

已修改。

@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Nov 24, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

image

/approve

Copy link

f2c-ci-robot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JohnNiang JohnNiang added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@ruibaby ruibaby merged commit 3306b1f into halo-dev:main Nov 27, 2023
4 checks passed
@ruibaby ruibaby deleted the feat/display-plugins-on-actuator-page branch November 27, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在 Console 概览的页面列出所有启用的插件和主题
3 participants