Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add delete function for user notification #4906

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

guqing
Copy link
Member

@guqing guqing commented Nov 24, 2023

What type of PR is this?

/kind feature
/area core
/area console

What this PR does / why we need it:

新增用户站内消息删除功能

图片

Which issue(s) this PR fixes:

Fixes #4706

Does this PR introduce a user-facing change?

新增用户站内消息删除功能

@f2c-ci-robot f2c-ci-robot bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/core Issues or PRs related to the Halo Core area/console Issues or PRs related to the Halo Console labels Nov 24, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen November 24, 2023 04:18
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (4ee4a8f) 56.88% compared to head (73d8740) 56.81%.
Report is 12 commits behind head on main.

Files Patch % Lines
...o/app/notification/DefaultNotificationService.java 0.00% 7 Missing ⚠️
...otification/endpoint/UserNotificationEndpoint.java 78.94% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4906      +/-   ##
============================================
- Coverage     56.88%   56.81%   -0.08%     
+ Complexity     2975     2972       -3     
============================================
  Files           514      515       +1     
  Lines         16912    16939      +27     
  Branches       1273     1274       +1     
============================================
+ Hits           9621     9624       +3     
- Misses         6750     6773      +23     
- Partials        541      542       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
@ruibaby
Copy link
Member

ruibaby commented Nov 24, 2023

/retitle feat: add delete function for user notification

Ready for review

@f2c-ci-robot f2c-ci-robot bot changed the title [WIP] feat: add delete function for user notification feat: add delete function for user notification Nov 24, 2023
@f2c-ci-robot f2c-ci-robot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link
Contributor

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases part is look good to me.

e2e/testsuite.yaml Outdated Show resolved Hide resolved
@ruibaby ruibaby added this to the 2.11.x milestone Nov 27, 2023
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
@f2c-ci-robot f2c-ci-robot bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link

f2c-ci-robot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 91affeb into halo-dev:main Nov 27, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.11.x, 2.11.0 Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

支持删除站内消息
4 participants