-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add delete function for user notification #4906
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4906 +/- ##
============================================
- Coverage 56.88% 56.81% -0.08%
+ Complexity 2975 2972 -3
============================================
Files 514 515 +1
Lines 16912 16939 +27
Branches 1273 1274 +1
============================================
+ Hits 9621 9624 +3
- Misses 6750 6773 +23
- Partials 541 542 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <i@ryanc.cc>
/retitle feat: add delete function for user notification Ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
application/src/main/java/run/halo/app/notification/endpoint/UserNotificationEndpoint.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test cases part is look good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
application/src/main/java/run/halo/app/notification/endpoint/UserNotificationEndpoint.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
/area core
/area console
What this PR does / why we need it:
新增用户站内消息删除功能
Which issue(s) this PR fixes:
Fixes #4706
Does this PR introduce a user-facing change?