Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overflow issue of card component #4922

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Nov 27, 2023

What type of PR is this?

/area console
/kind bug
/milestone 2.11.x

What this PR does / why we need it:

修复在 Card 组件中使用下拉组件无法完整显示的问题。

before:

图片

after:

图片

Which issue(s) this PR fixes:

Fixes #4921

Does this PR introduce a user-facing change?

修复在 Card 组件中使用下拉组件无法完整显示的问题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Nov 27, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.x milestone Nov 27, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from wan92hen November 27, 2023 06:44
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 27, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from wzrove November 27, 2023 06:44
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64fed0c) 56.81% compared to head (1ef1008) 56.81%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #4922   +/-   ##
=========================================
  Coverage     56.81%   56.81%           
  Complexity     2971     2971           
=========================================
  Files           515      515           
  Lines         16913    16913           
  Branches       1273     1273           
=========================================
  Hits           9609     9609           
  Misses         6762     6762           
  Partials        542      542           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 27, 2023
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2023
Copy link

f2c-ci-robot bot commented Nov 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 0102f7a into halo-dev:main Nov 27, 2023
4 checks passed
@ruibaby ruibaby deleted the fix/card-overflow branch November 27, 2023 09:04
@ruibaby ruibaby modified the milestones: 2.11.x, 2.11.0 Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

在 Card 组件中使用下拉框等组件时,超出的部分会被隐藏。
2 participants