chore: bump editor version and let it load globally #4924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
added
area/console
f2c-ci-robot
bot
added
area/editor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4924 +/- ##
============================================
- Coverage 56.81% 56.76% -0.05%
- Complexity 2971 2990 +19
============================================
Files 515 517 +2
Lines 16913 17131 +218
Branches 1273 1283 +10
============================================
+ Hits 9609 9725 +116
- Misses 6762 6862 +100
- Partials 542 544 +2 ☔ View full report in Codecov by Sentry. |
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
Jan 10, 2024
#### What type of PR is this? /area console /kind improvement /milestone 2.12.x #### What this PR does / why we need it: 将默认编辑器依赖添加到插件构建库的 external 中，基于 #4924 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area console
/area editor
/milestone 2.11.0
/kind improvement
What this PR does / why we need it:
升级编辑器依赖，并将其全局注册，此 PR 合并之后，插件如果需要扩展编辑器，则不必引入其中依赖，可以完全排除。
Which issue(s) this PR fixes:
Does this PR introduce a user-facing change?