-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add disallow access console option for custom role #4958
feat: add disallow access console option for custom role #4958
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4958 +/- ##
============================================
- Coverage 56.08% 56.07% -0.02%
+ Complexity 3032 3031 -1
============================================
Files 524 524
Lines 17663 17663
Branches 1319 1319
============================================
- Hits 9906 9904 -2
- Misses 7209 7210 +1
- Partials 548 549 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
关于 Post Editor
、Post Author
和 Post Contributor
角色是否需要设置能否进入 console,这些数据会在每次 Halo 启动的时候初始化,即使设置了也会被覆盖掉。
可以,需不需要加一个 |
Signed-off-by: Ryan Wang <i@ryanc.cc>
application/src/main/resources/extensions/role-template-uc-content.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Ryan Wang <i@ryanc.cc>
建议加上,如果用户想要自定义角色,我将提交另外 PR 再定义和个人中心相关的角色模板。 |
我直接在这个 PR 上加了。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/area console
/kind feature
/milestone 2.11.x
What this PR does / why we need it:
支持为自定义角色配置 禁止访问 Console 的选项。
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?