-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add role templates for posts in user center #4965
Add role templates for posts in user center #4965
Conversation
Signed-off-by: John Niang <johnniang@foxmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4965 +/- ##
============================================
- Coverage 56.07% 55.94% -0.13%
- Complexity 3031 3034 +3
============================================
Files 524 525 +1
Lines 17663 17816 +153
Branches 1319 1329 +10
============================================
+ Hits 9904 9967 +63
- Misses 7210 7300 +90
Partials 549 549 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <i@ryanc.cc>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
/area core
/milestone 2.11.0
What this PR does / why we need it:
This PR adds role templates for posts in user center for recreating more flexible roles. Related to #4866.
Does this PR introduce a user-facing change?