Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role templates for posts in user center #4965

Merged

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind cleanup
/area core
/milestone 2.11.0

What this PR does / why we need it:

This PR adds role templates for posts in user center for recreating more flexible roles. Related to #4866.

Does this PR introduce a user-facing change?

None

Signed-off-by: John Niang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 1, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.11.0 milestone Dec 1, 2023
@f2c-ci-robot f2c-ci-robot bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/core Issues or PRs related to the Halo Core labels Dec 1, 2023
@f2c-ci-robot f2c-ci-robot bot requested review from minliacom and ruibaby December 1, 2023 03:30
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a5639a8) 56.07% compared to head (6acd200) 55.94%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4965      +/-   ##
============================================
- Coverage     56.07%   55.94%   -0.13%     
- Complexity     3031     3034       +3     
============================================
  Files           524      525       +1     
  Lines         17663    17816     +153     
  Branches       1319     1329      +10     
============================================
+ Hits           9904     9967      +63     
- Misses         7210     7300      +90     
  Partials        549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 1, 2023
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Dec 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 0351a67 into halo-dev:main Dec 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants