Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ineffective single-character queries in labelSelector #5007

Merged
merged 3 commits into from
Dec 7, 2023
Merged

fix: ineffective single-character queries in labelSelector #5007

merged 3 commits into from
Dec 7, 2023

Conversation

OnlyTL
Copy link
Contributor

@OnlyTL OnlyTL commented Dec 7, 2023 •
edited by guqing
Loading

What this PR does / why we need it:
This PR resolves the reported bug in issue #5001,

Which issue(s) this PR fixes:

Fixes #5001

修复 labelSelector 单字符值查询无效的问题

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@f2c-ci-robot f2c-ci-robot bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Dec 7, 2023
@JohnNiang JohnNiang mentioned this pull request Dec 7, 2023
Closed
JohnNiang
JohnNiang reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OnlyTL，感谢提交 PR！

api/src/main/java/run/halo/app/extension/router/selector/Operator.java Show resolved Hide resolved
@guqing guqing changed the title Update Operator.java fix: ineffective single-character queries in labelSelector Dec 7, 2023
@guqing
Copy link
Member

guqing commented Dec 7, 2023 •
edited
Loading

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

需要点击上述的 badge 签署一下 CLA，同时请补充一下 Pull Request 对应的模板内容如 What this PR does

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 7, 2023
@guqing
Copy link
Member

guqing commented Dec 7, 2023

/kind bug
/area core
/milestone 2.12.x

@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 7, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Dec 7, 2023
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 7, 2023
JohnNiang
JohnNiang approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your first contribution!

/approve

@f2c-ci-robot f2c-ci-robot
Copy link

f2c-ci-robot bot commented Dec 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
ruibaby
ruibaby reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit 8b405fa into halo-dev:main Dec 7, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruibaby ruibaby ruibaby left review comments

@JohnNiang JohnNiang JohnNiang approved these changes

@lan-yonghui lan-yonghui Awaiting requested review from lan-yonghui

@minliacom minliacom Awaiting requested review from minliacom

Assignees

@ruibaby ruibaby

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.

当使用 labelSelector 查询时如果 label 的 value 只有一位如 1 解析不到 value
5 participants
@OnlyTL @CLAassistant @guqing @JohnNiang @ruibaby