Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record the user query conditions in the route query parameters #5071

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Dec 19, 2023

What type of PR is this?

/area console
/kind feature
/milestone 2.12.x

What this PR does / why we need it:

在用户数据管理列表页面路由中记录查询条件,包括分页信息、筛选信息等。可以保证在刷新页面或者切换路由返回时保留之前的查询状态。

图片

Which issue(s) this PR fixes:

Fixes #5060

Special notes for your reviewer:

需要测试:

  1. 用户管理列表的所有筛选项是否可以正常工作。
  2. 尝试设置部分筛选,然后刷新页面,观察筛选条件是否正常保留。

Does this PR introduce a user-facing change?

Console 端的用户管理列表支持在地址栏记录筛选条件。

@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 19, 2023
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Dec 19, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from Aanko December 19, 2023 07:56
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 19, 2023
@f2c-ci-robot f2c-ci-robot bot requested a review from QuentinHsu December 19, 2023 07:56
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b405fa) 55.94% compared to head (4cf23d5) 55.91%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5071      +/-   ##
============================================
- Coverage     55.94%   55.91%   -0.03%     
+ Complexity     3034     3032       -2     
============================================
  Files           525      524       -1     
  Lines         17816    17826      +10     
  Branches       1329     1329              
============================================
+ Hits           9967     9968       +1     
- Misses         7300     7309       +9     
  Partials        549      549              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2023
@ruibaby ruibaby requested review from JohnNiang and LIlGG December 21, 2023 02:29
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@f2c-ci-robot f2c-ci-robot bot merged commit cdd5cb4 into halo-dev:main Dec 21, 2023
4 checks passed
@JohnNiang JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 7, 2024
@ruibaby ruibaby deleted the feat/store-user-query-params branch May 27, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望 Console 的用户管理的查询条件可以保留状态
3 participants