-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: record the user query conditions in the route query parameters #5071
feat: record the user query conditions in the route query parameters #5071
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5071 +/- ##
============================================
- Coverage 55.94% 55.91% -0.03%
+ Complexity 3034 3032 -2
============================================
Files 525 524 -1
Lines 17816 17826 +10
Branches 1329 1329
============================================
+ Hits 9967 9968 +1
- Misses 7300 7309 +9
Partials 549 549 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind feature
/milestone 2.12.x
What this PR does / why we need it:
在用户数据管理列表页面路由中记录查询条件,包括分页信息、筛选信息等。可以保证在刷新页面或者切换路由返回时保留之前的查询状态。
Which issue(s) this PR fixes:
Fixes #5060
Special notes for your reviewer:
需要测试:
Does this PR introduce a user-facing change?