-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: visible condition of modal component #5078
refactor: visible condition of modal component #5078
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5078 +/- ##
=========================================
Coverage 55.91% 55.91%
Complexity 3032 3032
=========================================
Files 524 524
Lines 17826 17826
Branches 1329 1329
=========================================
Hits 9968 9968
Misses 7309 7309
Partials 549 549 ☔ View full report in Codecov by Sentry. |
ping @halo-dev/sig-halo-console |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
在 Halo 2.12 中重构了 Modal 组件的显示控制方式,此 PR 用于简化 Modal 弹窗的显示逻辑。 See halo-dev/halo#5078 /kind improvement ```release-note None ```
#### What type of PR is this? /kind bug /area ui /milestone 2.15.x #### What this PR does / why we need it: 修复由于 modal 延迟 200ms 所导致的数据可能为空的问题。 See #5078 #### How to test it? 反复点击并关闭附件库详情弹窗,查看是否会有空数据的问题 #### Which issue(s) this PR fixes: Fixes #5689 #### Does this PR introduce a user-facing change? ```release-note 修复附件详情弹窗可能无法显示数据的问题 ```
What type of PR is this?
/area console
/kind improvement
/milestone 2.12.x
What this PR does / why we need it:
重构 UI 的 Modal 组件,支持通过 v-if 控制是否显示(渲染)。
example:
Which issue(s) this PR fixes:
Fixes #5077
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?