fix: Backspace does not work properly behind list #5102

AirboZH · 2023-12-22T07:32:09Z

What type of PR is this?

/kind bug

What this PR does / why we need it:

增加 @tiptap/extension-list-keymap 扩展，优化列表的键盘操作

Which issue(s) this PR fixes:

Fixes #5065

Special notes for your reviewer:

测试方法：

测试无序列表中和无序列表后对于删除键 Delete 和退格键 backspace 的支持是否符合预期
测试有序列表中和有序列表后对于删除键 Delete 和退格键 backspace 的支持是否符合预期
测试选择部分列表项后对于删除键 Delete 和退格键 backspace 的支持是否符合预期
测试 Ctrl-A 全选后对于删除键 Delete 和退格键 backspace 的支持是否符合预期

Does this PR introduce a user-facing change?

修复编辑器中无法删除有序/无序列表后空行的问题

codecov · 2023-12-22T07:36:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (36ebc24) 55.91% compared to head (6b8f07a) 55.91%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #5102   +/-   ##
=========================================
  Coverage     55.91%   55.91%           
  Complexity     3032     3032           
=========================================
  Files           524      524           
  Lines         17826    17826           
  Branches       1329     1329           
=========================================
  Hits           9968     9968           
  Misses         7309     7309           
  Partials        549      549

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

LIlGG

hi， @AirboZH ，感谢提交的 PR。
经过测试，我发现此提交会对其他快捷键产生冲突。例如：

输入：

1. 123
2. 123

之后，按 Mod + a 进行全选，然后按删除键进行删除，此时只会删除 list item 的最后一个 item。
这应该是删除键与快捷键冲突导致，删除键遇到 item 的 li 标签后，将其还原为了普通文本就停止继续操作了。

AirboZH · 2023-12-22T08:36:25Z

经过测试，我发现此提交会对其他快捷键产生冲突。

🤨确实是我自测的时候没测到这个问题。

这是一个已知的问题，并且也有其他 tiptap下游软件受到影响。
ueberdosis/tiptap#4395
但是这其中的 PR 和 Issue 好像很久都没有人处理了。

我们可以等待上游处理。

同时，我也在看看有没有机会在 list-keymap extension 的基础上处理一下全选删除这个操作。

LIlGG · 2023-12-22T09:49:13Z

同时，我也在看看有没有机会在 list-keymap extension 的基础上处理一下全选删除这个操作。

tiptap 在写这个扩展的时候，将工具类 list-keymap 也导出了，那么只需要在 Halo 中重构扩展逻辑即可。

可以提供一种思路，例如在 Backspace 操作执行其余操作之前，先校验 selection 是否完全包含了当前 node 列表，如果包含，则执行 delete node 即可。

LIlGG · 2023-12-25T04:29:55Z

似乎还是有问题。当不是全选时，将会出现与之前同样的问题。

# Conflicts: # console/pnpm-lock.yaml

LIlGG

/lgtm

nice，它可以正常工作，很完美。

ruibaby

/lgtm

f2c-ci-robot · 2024-01-02T03:45:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LIlGG, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~console/OWNERS~~ [ruibaby]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JohnNiang · 2024-01-02T09:18:32Z

/milestone 2.12.x

…list (#92) #### What type of PR is this? /kind bug #### What this PR does / why we need it: 增加 keymap 扩展，用于解决列表组件无法使用退格键删除的问题。 See halo-dev/halo#5102 #### How to test it? 测试列表能否使用退格键删除 #### Which issue(s) this PR fixes: Fixes #91 #### Does this PR introduce a user-facing change? ```release-note 修复瞬间编辑区域列表组件无法被删除的问题 ```

f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Dec 22, 2023

f2c-ci-robot bot requested review from LIlGG and wan92hen December 22, 2023 07:32

LIlGG requested changes Dec 22, 2023

View reviewed changes

pref: Optimize list keymap

26a10ca

AirboZH closed this Dec 22, 2023

AirboZH force-pushed the main branch from 611801b to cdd5cb4 Compare December 22, 2023 13:54

AirboZH reopened this Dec 22, 2023

AirboZH requested a review from LIlGG December 22, 2023 13:58

Merge branch 'main' into main

8a57c4a

f2c-ci-robot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2023

AirboZH added 2 commits December 29, 2023 08:53

Merge branch 'main' into airbozh

7ca3ed9

# Conflicts: # console/pnpm-lock.yaml

pref: Optimize selection deletion

8f6faae

f2c-ci-robot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 29, 2023

chore: Supplement TS types

6b8f07a

AirboZH force-pushed the main branch from 514f03e to 6b8f07a Compare December 29, 2023 08:29

LIlGG approved these changes Dec 29, 2023

View reviewed changes

f2c-ci-robot bot assigned LIlGG Dec 29, 2023

f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 29, 2023

ruibaby approved these changes Jan 2, 2024

View reviewed changes

f2c-ci-robot bot assigned ruibaby Jan 2, 2024

f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024

f2c-ci-robot bot merged commit c918f2c into halo-dev:main Jan 2, 2024
4 checks passed

f2c-ci-robot bot added this to the 2.12.x milestone Jan 2, 2024

JohnNiang modified the milestones: 2.12.x, 2.12.0 Jan 7, 2024

LIlGG mentioned this pull request Apr 11, 2024

fix: add keymap to solve the problem of not being able to delete the list halo-sigs/plugin-moments#92

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Backspace does not work properly behind list #5102

fix: Backspace does not work properly behind list #5102

AirboZH commented Dec 22, 2023 •

edited by ruibaby

Loading

codecov bot commented Dec 22, 2023 •

edited

Loading

LIlGG left a comment

AirboZH commented Dec 22, 2023 •

edited

Loading

LIlGG commented Dec 22, 2023

LIlGG commented Dec 25, 2023

LIlGG left a comment

ruibaby left a comment

f2c-ci-robot bot commented Jan 2, 2024

JohnNiang commented Jan 2, 2024

fix: Backspace does not work properly behind list #5102

fix: Backspace does not work properly behind list #5102

Conversation

AirboZH commented Dec 22, 2023 • edited by ruibaby Loading

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

codecov bot commented Dec 22, 2023 • edited Loading

Codecov Report

LIlGG left a comment

Choose a reason for hiding this comment

AirboZH commented Dec 22, 2023 • edited Loading

LIlGG commented Dec 22, 2023

LIlGG commented Dec 25, 2023

LIlGG left a comment

Choose a reason for hiding this comment

ruibaby left a comment

Choose a reason for hiding this comment

f2c-ci-robot bot commented Jan 2, 2024

JohnNiang commented Jan 2, 2024

AirboZH commented Dec 22, 2023 •

edited by ruibaby

Loading

codecov bot commented Dec 22, 2023 •

edited

Loading

AirboZH commented Dec 22, 2023 •

edited

Loading