-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add vue dev tools #5134
chore: add vue dev tools #5134
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5134 +/- ##
=========================================
Coverage 57.07% 57.07%
Complexity 3327 3327
=========================================
Files 587 587
Lines 18958 18958
Branches 1400 1400
=========================================
Hits 10821 10821
Misses 7558 7558
Partials 579 579 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
用起来会影响到页面的速度,在我电脑上切换一个菜单都卡老半天 感觉非常影响使用 暂时不合并吧 |
Signed-off-by: Ryan Wang <i@ryanc.cc>
已升级版本,目前最新版本 7.0.13 已经不会再出现此问题。 |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area console
/kind improvement
/milestone 2.12.x
What this PR does / why we need it:
为 Console 和 UC 添加 Vue 社区新的 Dev Tools。
可以不再需要依赖浏览器插件。
Special notes for your reviewer:
后续也可以尝试为 Halo 的 UI 部分的插件机制适配 Dev Tools,参考:https://devtools-next.vuejs.org/plugins/api
Does this PR introduce a user-facing change?