Refactor workflow by not using composite actions from halo-sigs/actions #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Niang <johnniang@foxmail.com>
f2c-ci-robot
bot
added
kind/improvement
guqing
approved these changes
Jan 10, 2024
f2c-ci-robot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I will merge this PR manually due to workflow files changed. |
Closed
This was referenced Jan 14, 2024
f2c-ci-robot bot
pushed a commit
to halo-sigs/actions
that referenced
this pull request
Jan 19, 2024
This PR removes all unsed actions due to <halo-dev/halo#5170>. /kind cleanup ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.12.x
What this PR does / why we need it:
This PR refactors workflow by not using compiste actions from https://github.com/halo-sigs/actions and adds a support of publishing Halo artifact into GitHub release.
I have tested the new workflow in my repo, please see
After this PR, the repository https://github.com/halo-sigs/actions can be archived.
Which issue(s) this PR fixes:
Fixes #2996
Does this PR introduce a user-facing change?