-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve effect of menu expand #5244
refactor: improve effect of menu expand #5244
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5244 +/- ##
============================================
+ Coverage 57.06% 57.18% +0.12%
- Complexity 3333 3384 +51
============================================
Files 584 587 +3
Lines 19190 19235 +45
Branches 1444 1460 +16
============================================
+ Hits 10950 10999 +49
+ Misses 7664 7652 -12
- Partials 576 584 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/area console
/milestone 2.12.x
/kind improvement
What this PR does / why we need it:
优化 Console 左侧菜单的展开逻辑,改为可以通过点击展开图标来展开子菜单。
Does this PR introduce a user-facing change?