-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve the issue of the bubble menu being obscured #5246
fix: resolve the issue of the bubble menu being obscured #5246
Conversation
/milestone 2.12.x |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5246 +/- ##
=========================================
Coverage 57.18% 57.18%
Complexity 3384 3384
=========================================
Files 587 587
Lines 19235 19235
Branches 1460 1460
=========================================
Hits 10999 10999
Misses 7652 7652
Partials 584 584 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area console
/area editor
What this PR does / why we need it:
将默认编辑器的父级容器移除。用于解决冒泡菜单被遮挡的问题。
由于修改后默认编辑器自身可滚动,因此可以使默认编辑器容器内的绝对定位元素获取到当前滚动的位置。
How to test it?
输入超过一屏宽度的内容,按
MOD + A
全选,查看冒泡菜单是否被顶部菜单遮挡。Which issue(s) this PR fixes:
Fixes #4869
Does this PR introduce a user-facing change?