Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to request session keep-alive API when browser tabs are inactive #5266

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 29, 2024

What type of PR is this?

/area console
/kind bug
/milestone 2.12.x

What this PR does / why we need it:

修复当浏览器标签页不活跃时,文章编辑页面的 health 接口没有定时请求的问题。

Which issue(s) this PR fixes:

Fixes #5265

Special notes for your reviewer:

测试方式:

  1. 可以在本地先将 refetchInterval 改为 1000 以方便测试。
  2. 进入文章编辑页面。
  3. 切换至其他标签页。
  4. 返回之后查看浏览器开发者工具的 Network ,观察 health 接口是否有请求。

Does this PR introduce a user-facing change?

修复当浏览器标签页不活跃时,文章编辑页面的 health 接口没有定时请求的问题。

…nactive

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/console Issues or PRs related to the Halo Console release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jan 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 29, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and wzrove January 29, 2024 03:16
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bb81d8) 57.07% compared to head (7b49726) 57.07%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5266   +/-   ##
=========================================
  Coverage     57.07%   57.07%           
  Complexity     3327     3327           
=========================================
  Files           587      587           
  Lines         18958    18958           
  Branches       1400     1400           
=========================================
  Hits          10821    10821           
  Misses         7558     7558           
  Partials        579      579           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
@LIlGG
Copy link
Member

LIlGG commented Jan 29, 2024

/lgtm

@JohnNiang JohnNiang added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit cf72cbc into halo-dev:main Jan 29, 2024
7 checks passed
@ruibaby ruibaby deleted the fix/keep-alive branch January 29, 2024 08:39
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
4 participants