Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pat can not be copied #5274

Merged
merged 2 commits into from
Jan 29, 2024
Merged

fix: pat can not be copied #5274

merged 2 commits into from
Jan 29, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 29, 2024

What type of PR is this?

/area console
/kind bug
/milestone 2.12.x

What this PR does / why we need it:

修复创建 PAT 之后,点击复制按钮无法复制 token 的问题。

Which issue(s) this PR fixes:

Fixes #5273

Special notes for your reviewer:

测试步骤:

  1. 构建生产环境的 UC。
  2. 创建 PAT,点击复制按钮,观察是否能够正常复制。

Does this PR introduce a user-facing change?

修复创建 PAT 之后,点击复制按钮无法复制 token 的问题。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/console Issues or PRs related to the Halo Console labels Jan 29, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 29, 2024
@f2c-ci-robot f2c-ci-robot bot added the kind/bug Categorizes issue or PR as related to a bug. label Jan 29, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from QuentinHsu and wzrove January 29, 2024 08:56
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/lgtm

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47a1aa7) 57.08% compared to head (99eb680) 57.08%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5274   +/-   ##
=========================================
  Coverage     57.08%   57.08%           
  Complexity     3329     3329           
=========================================
  Files           587      587           
  Lines         18955    18955           
  Branches       1402     1402           
=========================================
  Hits          10820    10820           
  Misses         7557     7557           
  Partials        578      578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

功能符合预期

Copy link

f2c-ci-robot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2024
Copy link

f2c-ci-robot bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit e8a9f06 into halo-dev:main Jan 29, 2024
7 checks passed
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Jan 30, 2024
@ruibaby ruibaby deleted the fix/pat-copy branch January 30, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

创建个人令牌之后,复制按钮无效
3 participants