Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: data fetching of dashboard widgets #5280

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 30, 2024

What type of PR is this?

/area console
/kind improvement
/milestone 2.12.x

What this PR does / why we need it:

重构 Console 仪表盘中小部件的数据获取方式。

Does this PR introduce a user-facing change?

重构 Console 仪表盘中小部件的数据获取方式。

Signed-off-by: Ryan Wang <i@ryanc.cc>
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4e862c) 57.07% compared to head (1fedf16) 57.07%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5280   +/-   ##
=========================================
  Coverage     57.07%   57.07%           
  Complexity     3329     3329           
=========================================
  Files           587      587           
  Lines         18956    18956           
  Branches       1402     1402           
=========================================
  Hits          10820    10820           
  Misses         7558     7558           
  Partials        578      578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang JohnNiang added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. labels Jan 30, 2024
@JohnNiang JohnNiang added this to the 2.12.0 milestone Jan 30, 2024
Copy link

f2c-ci-robot bot commented Jan 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 831a19b into halo-dev:main Jan 30, 2024
8 checks passed
@ruibaby ruibaby deleted the refactor/dashboard-data-fetching branch January 30, 2024 07:42
@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants