Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add supports for ui permissions of notification reason type #5286

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 31, 2024

What type of PR is this?

/kind feature
/area core
/area console
/milestone 2.12.x

What this PR does / why we need it:

为通知类型设置添加 UI 权限判断。

Which issue(s) this PR fixes:

Fixes #4728

Special notes for your reviewer:

Does this PR introduce a user-facing change?

为通知类型设置添加 UI 权限判断。

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 31, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.12.x milestone Jan 31, 2024
@f2c-ci-robot f2c-ci-robot bot added area/core Issues or PRs related to the Halo Core area/console Issues or PRs related to the Halo Console labels Jan 31, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and wan92hen January 31, 2024 03:11
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (b4bf425) 57.07% compared to head (c37c060) 57.05%.
Report is 5 commits behind head on main.

Files Patch % Lines
.../endpoint/UserNotificationPreferencesEndpoint.java 9.09% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5286      +/-   ##
============================================
- Coverage     57.07%   57.05%   -0.03%     
  Complexity     3329     3329              
============================================
  Files           587      587              
  Lines         18956    18963       +7     
  Branches       1402     1402              
============================================
  Hits          10820    10820              
- Misses         7558     7565       +7     
  Partials        578      578              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guqing guqing force-pushed the feat/notification-reason-permissions branch from cd686ad to 859cbad Compare January 31, 2024 03:20
@ruibaby ruibaby requested review from JohnNiang and LIlGG January 31, 2024 03:45
@JohnNiang
Copy link
Member

Halo 2.12.0 已经进入 RC 阶段,建议不新增功能。当前修改建议合并到 2.13.0 中。

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ruibaby
Copy link
Member Author

ruibaby commented Jan 31, 2024

Halo 2.12.0 已经进入 RC 阶段,建议不新增功能。当前修改建议合并到 2.13.0 中。

但这也算是一个问题修复或者优化呀。

image

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang JohnNiang added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit e85a55e into halo-dev:main Jan 31, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.12.x, 2.12.0 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console area/core Issues or PRs related to the Halo Core kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

用户通知配置的通知类型需要权限控制
3 participants