Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue of non-template roles being displayed in personal token roles #5291

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jan 31, 2024

What type of PR is this?

/area console
/kind bug
/milestone 2.12.0

What this PR does / why we need it:

修复个人令牌创建表单中,角色设置显示了非模板角色的问题。

Which issue(s) this PR fixes:

Fixes #5288

Does this PR introduce a user-facing change?

修复个人令牌创建表单中,角色设置显示了非模板角色的问题。

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4bf425) 57.07% compared to head (7e9f812) 57.08%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5291   +/-   ##
=========================================
  Coverage     57.07%   57.08%           
- Complexity     3329     3330    +1     
=========================================
  Files           587      587           
  Lines         18956    18956           
  Branches       1402     1402           
=========================================
+ Hits          10820    10821    +1     
+ Misses         7558     7557    -1     
  Partials        578      578           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JohnNiang JohnNiang added kind/bug Categorizes issue or PR as related to a bug. area/console Issues or PRs related to the Halo Console labels Jan 31, 2024
@JohnNiang JohnNiang added this to the 2.12.0 milestone Jan 31, 2024
@JohnNiang JohnNiang added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 31, 2024
@JohnNiang JohnNiang merged commit 7543fb6 into halo-dev:main Jan 31, 2024
7 of 8 checks passed
Copy link

f2c-ci-robot bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/console Issues or PRs related to the Halo Console kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

个人令牌的权限列表会出现非角色模板的角色
3 participants