refactor: only select the required index fields when build query index view #5312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5312 +/- ##
============================================
+ Coverage 56.91% 56.92% +0.01%
- Complexity 3319 3342 +23
============================================
Files 587 588 +1
Lines 18968 19077 +109
Branches 1401 1409 +8
============================================
+ Hits 10795 10859 +64
- Misses 7594 7635 +41
- Partials 579 583 +4 ☔ View full report in Codecov by Sentry. |
f2c-ci-robot
bot
added
the
needs-rebase
…x view # Conflicts: # api/src/test/java/run/halo/app/extension/index/query/QueryFactoryTest.java # application/src/main/java/run/halo/app/extension/index/IndexedQueryEngineImpl.java
guqing
force-pushed
the
refactor/build-index-view
branch
from
a05044d to
97d5f89
Compare
f2c-ci-robot
bot
removed
the
needs-rebase
|
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
f2c-ci-robot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind improvement
/area core
/milestone 2.13.x
What this PR does / why we need it:
构建查询视图时只选择被使用到的索引字段
how to test it?
验证文章和附件列表的查询条件和排序条件不会报错即可
Does this PR introduce a user-facing change?