-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: failure in data query due to reconciler triggered by uncommitted transaction #5323
Conversation
@guqing: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/milestone 2.13.x |
/kind bug |
@guqing: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5323 +/- ##
============================================
+ Coverage 57.05% 57.14% +0.08%
- Complexity 3329 3336 +7
============================================
Files 587 587
Lines 18963 18977 +14
Branches 1402 1402
============================================
+ Hits 10820 10845 +25
+ Misses 7565 7554 -11
Partials 578 578 ☔ View full report in Codecov by Sentry. |
application/src/main/java/run/halo/app/extension/ReactiveExtensionClientImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/extension/ReactiveExtensionClientImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/extension/ReactiveExtensionClientImpl.java
Outdated
Show resolved
Hide resolved
application/src/main/java/run/halo/app/config/HaloConfiguration.java
Outdated
Show resolved
Hide resolved
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@guqing: new pull request created: #5329 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bugfix
/milestone 2.12.x
/area core
What this PR does / why we need it:
修复事务未提交便触发控制器执行可能导致数据状态不正确的问题
how to test it?
Which issue(s) this PR fixes:
Fixes #5315
Does this PR introduce a user-facing change?