-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove unnecessary indices build process for lucene on startup #5332
chore: remove unnecessary indices build process for lucene on startup #5332
Conversation
/cherry-pick release-2.12 |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5332 +/- ##
============================================
- Coverage 57.14% 56.91% -0.24%
+ Complexity 3335 3319 -16
============================================
Files 587 587
Lines 18977 18968 -9
Branches 1402 1401 -1
============================================
- Hits 10844 10795 -49
- Misses 7555 7594 +39
- Partials 578 579 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
同意,每次启动时都查询所有已发布的文章确实不太合理。
/cherry-pick release-2.12 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@guqing: new pull request created: #5333 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind cleanup
/area core
/milestone 2.13.x
What this PR does / why we need it:
移除启动时不必要的搜索引擎索引构建步骤
Does this PR introduce a user-facing change?