Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the error when saving settings for posts in the uc #5370

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Feb 19, 2024

What type of PR is this?

/kind bug
/area ui

What this PR does / why we need it:

在个人中心的文章功能中,点击设置时并不会重新获取最新的 Post 数据,进而导致点击保存时的 version 并非最新版本而报错。
此 PR 将在个人中心的文章页面点击设置时,额外增加一次获取最新的 Post 数据的请求,用于解决此问题。

How to test it?

  1. 进入个人中心
  2. 点击文章菜单
  3. 点击右上角创建按钮
  4. 在编辑器中随便输入内容
  5. 点击保存
  6. 修改文章的设置后点击保存。
  7. 关闭设置框,再次打开设置框,然后点击保存。
  8. 查看是否会出现无法保存的问题。

Which issue(s) this PR fixes:

Fixes #5344

Does this PR introduce a user-facing change?

解决个人中心文章设置时报错的问题

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. area/ui Issues or PRs related to the Halo UI labels Feb 19, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from ruibaby and wzrove February 19, 2024 04:47
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fdf6c0) 56.91% compared to head (1eae968) 56.90%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5370      +/-   ##
============================================
- Coverage     56.91%   56.90%   -0.01%     
+ Complexity     3319     3316       -3     
============================================
  Files           587      587              
  Lines         18968    18967       -1     
  Branches       1401     1401              
============================================
- Hits          10795    10793       -2     
- Misses         7594     7595       +1     
  Partials        579      579              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruibaby ruibaby changed the title fix: fix the error when saving settings for articles in the uc fix: fix the error when saving settings for in the uc Feb 19, 2024
@ruibaby ruibaby changed the title fix: fix the error when saving settings for in the uc fix: fix the error when saving settings for posts in the uc Feb 19, 2024
@LIlGG
Copy link
Member Author

LIlGG commented Feb 19, 2024

/cherry-pick release-2.12

@halo-dev-bot
Copy link
Collaborator

@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LIlGG LIlGG added this to the 2.13.x milestone Feb 19, 2024
@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@guqing
Copy link
Member

guqing commented Feb 19, 2024

/remove-approve

@f2c-ci-robot f2c-ci-robot bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@guqing
Copy link
Member

guqing commented Feb 19, 2024

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 20, 2024
Copy link

f2c-ci-robot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 27c98ae into halo-dev:main Feb 20, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@LIlGG: new pull request created: #5375

In response to this:

/cherry-pick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

f2c-ci-robot bot pushed a commit that referenced this pull request Feb 20, 2024
…he uc (#5375)

This is an automated cherry-pick of #5370

/assign LIlGG

```release-note
解决个人中心文章设置时报错的问题
```
@LIlGG LIlGG deleted the fix/uc-post-setting-version branch February 21, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

升级到2.12.2版本,在发布之前进行文章设置会报服务器内部错误
5 participants