-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix the error when saving settings for posts in the uc #5370
fix: fix the error when saving settings for posts in the uc #5370
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5370 +/- ##
============================================
- Coverage 56.91% 56.90% -0.01%
+ Complexity 3319 3316 -3
============================================
Files 587 587
Lines 18968 18967 -1
Branches 1401 1401
============================================
- Hits 10795 10793 -2
- Misses 7594 7595 +1
Partials 579 579 ☔ View full report in Codecov by Sentry. |
/cherry-pick release-2.12 |
@LIlGG: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-approve |
/approve |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works very well.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@LIlGG: new pull request created: #5375 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area ui
What this PR does / why we need it:
在个人中心的文章功能中,点击设置时并不会重新获取最新的 Post 数据,进而导致点击保存时的
version
并非最新版本而报错。此 PR 将在个人中心的文章页面点击设置时,额外增加一次获取最新的 Post 数据的请求,用于解决此问题。
How to test it?
Which issue(s) this PR fixes:
Fixes #5344
Does this PR introduce a user-facing change?