Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump tiptap version to 2.2.3 #5382

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Feb 21, 2024

What type of PR is this?

/kind improvement
/area ui
/milestone 2.13.x

What this PR does / why we need it:

升级 Tiptap 依赖至 https://github.com/ueberdosis/tiptap/releases/tag/v2.2.3

Special notes for your reviewer:

测试方式:

  1. ./gradlew :ui:build
  2. 测试编辑器的已有功能是否正常。
  3. 安装若干已有编辑器插件,测试插件的功能是否正常。

Does this PR introduce a user-facing change?

升级 Tiptap 依赖至 [2.2.3](https://github.com/ueberdosis/tiptap/releases/tag/v2.2.3)。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 21, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 21, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/ui Issues or PRs related to the Halo UI label Feb 21, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and LIlGG February 21, 2024 03:16
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fdf6c0) 56.91% compared to head (9cc2eb2) 56.90%.
Report is 16 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5382      +/-   ##
============================================
- Coverage     56.91%   56.90%   -0.01%     
+ Complexity     3319     3315       -4     
============================================
  Files           587      587              
  Lines         18968    18953      -15     
  Branches       1401     1399       -2     
============================================
- Hits          10795    10785      -10     
+ Misses         7594     7588       -6     
- Partials        579      580       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link

f2c-ci-robot bot commented Feb 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 14da9c9 into halo-dev:main Feb 21, 2024
8 checks passed
@ruibaby ruibaby deleted the chore/bump-tiptap-version-2.2.3 branch February 21, 2024 03:44
@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants