-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump formkit version to 1.5.x #5395
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
单元测试失败了,需要修复一下 |
/hold 升级之后有不少类型问题,先 hold。 |
Signed-off-by: Ryan Wang <i@ryanc.cc>
Signed-off-by: Ryan Wang <i@ryanc.cc>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5395 +/- ##
============================================
+ Coverage 56.91% 56.92% +0.01%
- Complexity 3319 3345 +26
============================================
Files 587 589 +2
Lines 18968 19145 +177
Branches 1401 1394 -7
============================================
+ Hits 10795 10899 +104
- Misses 7594 7663 +69
- Partials 579 583 +4 ☔ View full report in Codecov by Sentry. |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
What type of PR is this?
/area ui
/kind improvement
/milestone 2.13.x
What this PR does / why we need it:
升级 FormKit 的依赖版本至 1.5.x
Please see https://formkit.com/changelog#_150
Does this PR introduce a user-facing change?