Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the problem of being unable to login when 2FA was enabled but TOTP was not configured #5400

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

JohnNiang
Copy link
Member

What type of PR is this?

/kind bug
/area core
/milestone 2.13.x

What this PR does / why we need it:

This PR ignored email verified status while 2FA was enabled.

Which issue(s) this PR fixes:

Fixes #5398

Does this PR introduce a user-facing change?

修复开启两步验证但未配置 TOTP 可能无法登录的问题

Signed-off-by: John Niang <johnniang@foxmail.com>
@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels Feb 24, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.13.x milestone Feb 24, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label Feb 24, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.84%. Comparing base (5fdf6c0) to head (32fe8eb).
Report is 23 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5400      +/-   ##
============================================
- Coverage     56.91%   56.84%   -0.07%     
- Complexity     3319     3330      +11     
============================================
  Files           587      588       +1     
  Lines         18968    19048      +80     
  Branches       1401     1402       +1     
============================================
+ Hits          10795    10828      +33     
- Misses         7594     7639      +45     
- Partials        579      581       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnNiang
Copy link
Member Author

/cherrypick release-2.12

@halo-dev-bot
Copy link
Collaborator

@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you.

In response to this:

/cherrypick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2024
Copy link

f2c-ci-robot bot commented Feb 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit b6edb0c into halo-dev:main Feb 25, 2024
8 checks passed
@halo-dev-bot
Copy link
Collaborator

@JohnNiang: new pull request created: #5401

In response to this:

/cherrypick release-2.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ruibaby ruibaby modified the milestones: 2.13.x, 2.13.0 Feb 25, 2024
f2c-ci-robot bot pushed a commit that referenced this pull request Feb 25, 2024
…enabled but TOTP was not configured (#5401)

This is an automated cherry-pick of #5400

/assign JohnNiang

```release-note
修复开启两步验证但未配置 TOTP 可能无法登录的问题
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

开启两步验证但未设置 TOTP 时,无法正常登录
3 participants