-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the problem of being unable to login when 2FA was enabled but TOTP was not configured #5400
Conversation
Signed-off-by: John Niang <johnniang@foxmail.com>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5400 +/- ##
============================================
- Coverage 56.91% 56.84% -0.07%
- Complexity 3319 3330 +11
============================================
Files 587 588 +1
Lines 18968 19048 +80
Branches 1401 1402 +1
============================================
+ Hits 10795 10828 +33
- Misses 7594 7639 +45
- Partials 579 581 +2 ☔ View full report in Codecov by Sentry. |
/cherrypick release-2.12 |
@JohnNiang: once the present PR merges, I will cherry-pick it on top of release-2.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@JohnNiang: new pull request created: #5401 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
/area core
/milestone 2.13.x
What this PR does / why we need it:
This PR ignored
email verified
status while 2FA was enabled.Which issue(s) this PR fixes:
Fixes #5398
Does this PR introduce a user-facing change?