-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: optimize notification and subscription query using index #5414
refactor: optimize notification and subscription query using index #5414
Conversation
/ping @ruibaby 通知查询的参数有变动需要重新生成 api-client 并配置,将查询字段都改为对应的 spec.xxx |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5414 +/- ##
============================================
+ Coverage 56.91% 56.92% +0.01%
- Complexity 3319 3345 +26
============================================
Files 587 589 +2
Lines 18968 19145 +177
Branches 1401 1394 -7
============================================
+ Hits 10795 10899 +104
- Misses 7594 7663 +69
- Partials 579 583 +4 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryan Wang <i@ryanc.cc>
Done |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works very well.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind improvement
/area core
/milestone 2.13.x
What this PR does / why we need it:
使用索引机制优化通知和订阅查询以提高性能
how to test it
测试通知列表不报错即可
Does this PR introduce a user-facing change?