Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add select all shortcut function to the table #5443

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Mar 5, 2024

What type of PR is this?

/area editor
/area ui
/kind feature
/milestone 2.14.x

What this PR does / why we need it:

为默认富文本编辑器中的表格,增加全选快捷键。具体操作逻辑如下:

  1. 当光标处于表格中单元格内时,按 Mod + a 全选快捷键后,若未选中当前单元格,则选中单元格。
  2. 若其中包含有其他影响全选快捷键的组件,则以组件自身为准,例如代码块中的全选。
  3. 若已经选中单元格,则再次按全选快捷键,选中整个表格。
  4. 若已经选中表格,则再按全选快捷键不会触发其他全选事件。

How to test it?

按照操作逻辑测试全选快捷键逻辑是否无误。是否与其他快捷键产生冲突。

Which issue(s) this PR fixes:

Fixes #5438

Does this PR introduce a user-facing change?

为富文本编辑器中的表格组件增加全选快捷键

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/editor Issues or PRs related to the Editor labels Mar 5, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 5, 2024
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. labels Mar 5, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and QuentinHsu March 5, 2024 03:44
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.92%. Comparing base (5fdf6c0) to head (e0eaf39).
Report is 40 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5443      +/-   ##
============================================
+ Coverage     56.91%   56.92%   +0.01%     
- Complexity     3319     3345      +26     
============================================
  Files           587      589       +2     
  Lines         18968    19145     +177     
  Branches       1401     1394       -7     
============================================
+ Hits          10795    10899     +104     
- Misses         7594     7663      +69     
- Partials        579      583       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2024
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works very well.

/approve

Copy link

f2c-ci-robot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit 71d97b2 into halo-dev:main Mar 6, 2024
8 checks passed
@LIlGG LIlGG deleted the feat/add-table-select-all branch March 6, 2024 06:52
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

为富文本编辑器中的表格单元格添加全选快捷键
3 participants