Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pref: remove nofollow from the default editor link #5477

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

LIlGG
Copy link
Member

@LIlGG LIlGG commented Mar 8, 2024

What type of PR is this?

/kind improvement
/area editor
/area ui
/milestone 2.14.x

What this PR does / why we need it:

将默认富文本编辑器中的链接中的 rel 属性由默认的 noopener noreferrer nofollow 属性改为 null,优化 SEO 。

How to test it?

查看使用默认富文本编辑器创建的链接,其 rel 属性是否不再是 noopener noreferrer nofollow

Which issue(s) this PR fixes:

Fixes #5328

Does this PR introduce a user-facing change?

移除默认富文本编辑器中链接的 nofollow 等属性,优化 SEO。

@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 8, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.x milestone Mar 8, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from JohnNiang and QuentinHsu March 8, 2024 09:15
@f2c-ci-robot f2c-ci-robot bot added area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI labels Mar 8, 2024
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.86%. Comparing base (5fdf6c0) to head (83f7ad0).
Report is 44 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5477      +/-   ##
============================================
- Coverage     56.91%   56.86%   -0.05%     
- Complexity     3319     3341      +22     
============================================
  Files           587      589       +2     
  Lines         18968    19144     +176     
  Branches       1401     1394       -7     
============================================
+ Hits          10795    10887      +92     
- Misses         7594     7674      +80     
- Partials        579      583       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link

f2c-ci-robot bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot merged commit 92f2229 into halo-dev:main Mar 8, 2024
8 checks passed
@ruibaby ruibaby modified the milestones: 2.14.x, 2.14.0 Mar 11, 2024
@LIlGG LIlGG deleted the pref/editor-link-rel-nofollow branch October 8, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/editor Issues or PRs related to the Editor area/ui Issues or PRs related to the Halo UI kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

链接支持设定nofollow
3 participants