Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: attachments supports sorting by display name #5494

Merged

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Mar 11, 2024

What type of PR is this?

/area ui
/kind feature
/milestone 2.14.0

What this PR does / why we need it:

附件管理的排序功能支持按照文件名排序。

Which issue(s) this PR fixes:

Fixes #5028

Special notes for your reviewer:

测试方式:

  1. 上传若干附件。
  2. 测试根据文件名降序/升序功能是否符合预期。

Does this PR introduce a user-facing change?

附件管理的排序功能支持按照文件名排序。

Signed-off-by: Ryan Wang <i@ryanc.cc>
@f2c-ci-robot f2c-ci-robot bot added area/ui Issues or PRs related to the Halo UI release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 11, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.14.0 milestone Mar 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from guqing March 11, 2024 06:11
@f2c-ci-robot f2c-ci-robot bot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 11, 2024
@f2c-ci-robot f2c-ci-robot bot requested a review from JohnNiang March 11, 2024 06:11
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.81%. Comparing base (5fdf6c0) to head (bbd8303).
Report is 48 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5494      +/-   ##
============================================
- Coverage     56.91%   56.81%   -0.10%     
- Complexity     3319     3321       +2     
============================================
  Files           587      589       +2     
  Lines         18968    19082     +114     
  Branches       1401     1365      -36     
============================================
+ Hits          10795    10841      +46     
- Misses         7594     7668      +74     
+ Partials        579      573       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works very well

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 11, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
Copy link

f2c-ci-robot bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit 014625f into halo-dev:main Mar 11, 2024
8 checks passed
@ruibaby ruibaby deleted the feat/attachment-displayname-sort branch March 11, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ui Issues or PRs related to the Halo UI kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

建议增加附件按文件名排序功能
3 participants