-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: attachments supports sorting by display name #5494
feat: attachments supports sorting by display name #5494
Conversation
Signed-off-by: Ryan Wang <i@ryanc.cc>
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5494 +/- ##
============================================
- Coverage 56.91% 56.81% -0.10%
- Complexity 3319 3321 +2
============================================
Files 587 589 +2
Lines 18968 19082 +114
Branches 1401 1365 -36
============================================
+ Hits 10795 10841 +46
- Misses 7594 7668 +74
+ Partials 579 573 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works very well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: guqing, LIlGG The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/area ui
/kind feature
/milestone 2.14.0
What this PR does / why we need it:
附件管理的排序功能支持按照文件名排序。
Which issue(s) this PR fixes:
Fixes #5028
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?